From dev-return-72652-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Thu Aug 30 20:19:16 2018
Return-Path: <dev-return-72652-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id F3F01180656
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 30 Aug 2018 20:19:15 +0200 (CEST)
Received: (qmail 37981 invoked by uid 500); 30 Aug 2018 18:19:15 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 37970 invoked by uid 99); 30 Aug 2018 18:19:14 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Aug 2018 18:19:14 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 400D0E04A3; Thu, 30 Aug 2018 18:19:14 +0000 (UTC)
From: lvfangmin <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-601-zookeeper@git.apache.org>
In-Reply-To: <git-pr-601-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper issue #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooK...
Content-Type: text/plain
Message-Id: <20180830181914.400D0E04A3@git1-us-west.apache.org>
Date: Thu, 30 Aug 2018 18:19:14 +0000 (UTC)

Github user lvfangmin commented on the issue:

    https://github.com/apache/zookeeper/pull/601
  
    Thanks @eolivelli, the updated diff LGTM, let's keep this open for a few more days to see if there is any other comments, I'll accept it if there is none.


---