From dev-return-72578-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Mon Aug 27 16:47:52 2018
Return-Path: <dev-return-72578-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 3F8D3180674
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 27 Aug 2018 16:47:52 +0200 (CEST)
Received: (qmail 54359 invoked by uid 500); 27 Aug 2018 14:47:51 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 54343 invoked by uid 99); 27 Aug 2018 14:47:50 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Aug 2018 14:47:50 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 7DA9FE04A3; Mon, 27 Aug 2018 14:47:50 +0000 (UTC)
From: eolivelli <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-601-zookeeper@git.apache.org>
In-Reply-To: <git-pr-601-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle ...
Content-Type: text/plain
Message-Id: <20180827144750.7DA9FE04A3@git1-us-west.apache.org>
Date: Mon, 27 Aug 2018 14:47:50 +0000 (UTC)

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/601#discussion_r213002472
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java ---
    @@ -117,13 +121,23 @@ public void runFromConfig(ServerConfig config)
             LOG.info("Starting server");
             FileTxnSnapLog txnLog = null;
             try {
    +            try {
    +                metricsProvider = MetricsProviderBootstrap
    +                        .startMetricsProvider(config.metricsProviderClassName, new Properties());
    +            } catch (MetricsProviderLifeCycleException error) {
    +                LOG.error("Cannot boot MetricsProvider {}", config.metricsProviderClassName, error);
    +                throw new IOException("Cannot boot MetricsProvider "+config.metricsProviderClassName,
    --- End diff --
    
    @lvfangmin I can change it if you feel strong.


---