From dev-return-72414-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Aug 19 12:01:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 25584180656 for ; Sun, 19 Aug 2018 12:01:52 +0200 (CEST) Received: (qmail 82946 invoked by uid 500); 19 Aug 2018 10:01:52 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 82887 invoked by uid 99); 19 Aug 2018 10:01:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Aug 2018 10:01:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id ECB67E0A44; Sun, 19 Aug 2018 10:01:50 +0000 (UTC) From: maoling To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #593: [ZOOKEEPER-3111] Add socket buffer size option ... Content-Type: text/plain Message-Id: <20180819100150.ECB67E0A44@git1-us-west.apache.org> Date: Sun, 19 Aug 2018 10:01:50 +0000 (UTC) Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/593#discussion_r211097828 --- Diff: src/java/main/org/apache/zookeeper/server/SocketUtil.java --- @@ -0,0 +1,63 @@ +package org.apache.zookeeper.server; + +import java.net.ServerSocket; +import java.net.Socket; +import java.net.SocketAddress; +import java.net.SocketException; +import java.io.IOException; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class SocketUtil { + + private static final Logger LOG = LoggerFactory.getLogger(SocketUtil.class); + + public static final String NETWORK_BUFFER_SIZE = "zookeeper.NetworkBufferSize"; + protected static int networkBufferSize; --- End diff -- all the Java system property starts with lowercase,so `zookeeper.networkBufferSize`(same with the document) is better? ---