From dev-return-72186-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Wed Aug  8 11:02:07 2018
Return-Path: <dev-return-72186-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id CB503180600
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  8 Aug 2018 11:02:06 +0200 (CEST)
Received: (qmail 4006 invoked by uid 500); 8 Aug 2018 09:02:05 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 3983 invoked by uid 99); 8 Aug 2018 09:02:05 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2018 09:02:05 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 16BDDE04A3; Wed,  8 Aug 2018 09:02:05 +0000 (UTC)
From: anmolnar <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-545-zookeeper@git.apache.org>
In-Reply-To: <git-pr-545-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #545: ZOOKEEPER-2261 When only secureClientPort is co...
Content-Type: text/plain
Message-Id: <20180808090205.16BDDE04A3@git1-us-west.apache.org>
Date: Wed,  8 Aug 2018 09:02:05 +0000 (UTC)

Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/545#discussion_r208507660
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -122,8 +122,8 @@
         final Map<String, ChangeRecord> outstandingChangesForPath =
             new HashMap<String, ChangeRecord>();
     
    -    protected ServerCnxnFactory serverCnxnFactory;
    -    protected ServerCnxnFactory secureServerCnxnFactory;
    +    ServerCnxnFactory serverCnxnFactory;
    --- End diff --
    
    Intellij suggested. I think because it's more restrictive.


---