From dev-return-72120-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Aug 6 16:48:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D5E33180627 for ; Mon, 6 Aug 2018 16:48:13 +0200 (CEST) Received: (qmail 14225 invoked by uid 500); 6 Aug 2018 14:48:12 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 14214 invoked by uid 99); 6 Aug 2018 14:48:12 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Aug 2018 14:48:12 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1373BDFF92; Mon, 6 Aug 2018 14:48:12 +0000 (UTC) From: eolivelli To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #580: ZOOKEEPER-3098: Add additional server metrics Content-Type: text/plain Message-Id: <20180806144812.1373BDFF92@git1-us-west.apache.org> Date: Mon, 6 Aug 2018 14:48:12 +0000 (UTC) Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/580 @anmolnar this change is a backport from Facebook fork. in PR #582 I have started a brand new work, to design and implement a long term ZK internal API to instrument server and client java code base. Users are requesting support for Prometheus for instance. The idea of PR #582 is to design how a "MetricsProvider" can interact with ZK code. This great work from @jtuple and his collegues will be (quite) easily refactored to the new system once we have merged Facebook contribs and merged the new system. On the new Metrics API the most interesting key points are: - we are going to support several providers and/or let the users contribute/use other own providers - we are not using 'static' variables, so you can have several ZooKeeper clients (for instance a HBase client, a Curator based client...) inside the same JVM I would like to move forward and send the next patches but we need to have agreement on the high level decisions cc @hanm @phunt ---