From dev-return-72108-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Aug 6 15:36:33 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2E20B180627 for ; Mon, 6 Aug 2018 15:36:33 +0200 (CEST) Received: (qmail 52322 invoked by uid 500); 6 Aug 2018 13:36:32 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 52311 invoked by uid 99); 6 Aug 2018 13:36:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Aug 2018 13:36:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 66DBADFC7C; Mon, 6 Aug 2018 13:36:31 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #580: ZOOKEEPER-3098: Add additional server metrics Content-Type: text/plain Message-Id: <20180806133631.66DBADFC7C@git1-us-west.apache.org> Date: Mon, 6 Aug 2018 13:36:31 +0000 (UTC) Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/580#discussion_r207891221 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -33,17 +34,17 @@ public class ServerStats { private static final Logger LOG = LoggerFactory.getLogger(ServerStats.class); - private long packetsSent; - private long packetsReceived; - private long maxLatency; - private long minLatency = Long.MAX_VALUE; - private long totalLatency = 0; - private long count = 0; + private final AtomicLong packetsSent = new AtomicLong(); --- End diff -- Why are these 3 not part of `ServerMetrics`? Is that a future step of the migration? ---