From dev-return-72068-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Fri Aug  3 20:40:30 2018
Return-Path: <dev-return-72068-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 1A32F180647
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  3 Aug 2018 20:40:29 +0200 (CEST)
Received: (qmail 85393 invoked by uid 500); 3 Aug 2018 18:40:29 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 85382 invoked by uid 99); 3 Aug 2018 18:40:28 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2018 18:40:28 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 5AB4DDFB1C; Fri,  3 Aug 2018 18:40:28 +0000 (UTC)
From: jtuple <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-580-zookeeper@git.apache.org>
In-Reply-To: <git-pr-580-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #580: ZOOKEEPER-3098: Add additional server metrics
Content-Type: text/plain
Message-Id: <20180803184028.5AB4DDFB1C@git1-us-west.apache.org>
Date: Fri,  3 Aug 2018 18:40:28 +0000 (UTC)

Github user jtuple commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/580#discussion_r207633573
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
    @@ -271,7 +271,7 @@ private boolean checkFourLetterWord(final Channel channel,
             String cmd = FourLetterCommands.getCommandString(len);
     
             channel.setInterestOps(0).awaitUninterruptibly();
    -        packetReceived();
    +        packetReceived(4);
    --- End diff --
    
    `packetReceived()` now takes in the packet-size as an argument to update the packets received metric. The total packet size consists of packet header (4 bytes) + packet size. For "four letter words", there is no packet size -- just the 4-byte packet header.


---