zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eolivelli <...@git.apache.org>
Subject [GitHub] zookeeper pull request #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle ...
Date Fri, 17 Aug 2018 13:17:57 GMT
GitHub user eolivelli opened a pull request:


    WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper Server

    Manage the lifecycle of a MetricsProvider inside a ZooKeeper server.
    - handle configuration
    - start and configure the MetricsProvider
    - notify shutdown to the MetricsProvider
    This is an early preview, because there are some points to discuss:
    - We have to throw an IOException in case of failure (in order not to change the current
signature of main methods used to start the server)
    - The patch only provides the lifecycle, it introduces some dead fields (root metrics
context), this is expected as the real instrumentation will be done in a further step, is
it okay ?
    - Test cases cover only standalone mode, do we need to add a new suite for testing configuration
and boot errors on QuorumPeer mode ? (the answer should be YES)
    - MetricsProvider configuration is not subject to dynamic 'reconfig'
    Configuration to the MetricsProvider is not yet handled, the idea is to let the user configure
properties like
    in this case the MetricsProvider will receive {customParam1=value1, customParam2=value2}
as parameter in configure()
    is it okay ?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eolivelli/zookeeper fix/boot-provider

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #601
commit 11528f62175930fd02f7734ec65454ef0f86d817
Author: Enrico Olivelli <eolivelli@...>
Date:   2018-08-17T13:08:59Z

    ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper Server



View raw message