zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3127) Fixing potential data inconsistency due to update last processed zxid with partial multi-op txn
Date Tue, 28 Aug 2018 18:06:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595382#comment-16595382
] 

Hadoop QA commented on ZOOKEEPER-3127:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2098//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2098//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2098//console

This message is automatically generated.

> Fixing potential data inconsistency due to update last processed zxid with partial multi-op
txn
> -----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-3127
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3127
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.4, 3.6.0, 3.4.13
>            Reporter: Fangmin Lv
>            Assignee: Fangmin Lv
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.5.5, 3.4.14
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Found this issue while checking the code for another issue, this is a relatively rare
case which we haven't seen it on prod so far.
> Currently, the lastProcessedZxid is updated when applying the first txn of multi-op,
if there is a snapshot in progress, it's possible that the zxid associated with the snapshot
only include partial of the multi op.
> When loading snapshot, it will only load the txns after the zxid associated with snapshot
file, which could data inconsistency due to missing sub txns.
> To avoid this, we only update the lastProcessedZxid when the whole multi-op txn is applied
to DataTree.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message