zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3116) Make the DataTree.approximateDataSize more efficient
Date Wed, 22 Aug 2018 19:13:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589269#comment-16589269
] 

Hadoop QA commented on ZOOKEEPER-3116:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2078//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2078//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2078//console

This message is automatically generated.

> Make the DataTree.approximateDataSize more efficient
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-3116
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3116
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Fangmin Lv
>            Assignee: Fangmin Lv
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.6.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The approximateDataSize is a nice metric to show what's the total size stored in ZooKeeper
ensemble over time, but it's expensive to query too often, since each query will go through
all the nodes to calculate the total size.
> It's better to use a counter to record the total data size when txns applied to the
DataTree, which is cheaper.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message