zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Karan Mehta <karanmeht...@gmail.com>
Subject Re: Jute max buffer size related question
Date Wed, 29 Aug 2018 07:20:04 GMT
Got it. That makes sense. Thanks!
Let me know your thoughts on
https://issues.apache.org/jira/browse/ZOOKEEPER-3129

Karan

On Fri, Aug 24, 2018 at 6:10 PM Benjamin Reed <breed@apache.org> wrote:

> we stop reading the socket once we hit max buffer size so we don't
> overflow memory. it was put in when a buggy client cause the server to
> think it was getting a 1G packet and ran out of memory trying to
> allocate memory for it. in theory we could read in the data and just
> drop it on the floor. this would allow us to get to the next packet,
> but really this is a sanity check. if the packets are coming in that
> big, the client is insane, so we need to drop them.
>
> ben
> On Thu, Aug 23, 2018 at 11:01 PM Karan Mehta <karanmehta93@gmail.com>
> wrote:
> >
> > Hello everyone,
> >
> > Why do we close the clientCnxn whenever a client sends a request which
> > payload larger than jute max buffer size? (and similar for client as
> well)
> >
> > Is it a security issue if we send a relevant KeeperException instead?
> Even
> > more, we send the parameter value to the client and client can chunk up
> > request accordingly? If not, can somebody elaborate on the reason.
> >
> > Thanks
> > Karan
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message