zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eolivelli <...@git.apache.org>
Subject [GitHub] zookeeper pull request #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle ...
Date Mon, 27 Aug 2018 14:46:15 GMT
Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/601#discussion_r213001935
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java ---
    @@ -159,6 +173,7 @@ public void runFromConfig(QuorumPeerConfig config)
               }
     
               quorumPeer = getQuorumPeer();
    +          quorumPeer.setRootMetricsContext(metricsProvider.getRootContext());
    --- End diff --
    
    No, MetricsProvider will be stopped in the finally block, it is better that QuorumPeerMain
creates, starts and stops it


---

Mime
View raw message