zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eolivelli <...@git.apache.org>
Subject [GitHub] zookeeper pull request #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle ...
Date Fri, 24 Aug 2018 10:33:15 GMT
Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/601#discussion_r212587862
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -325,6 +327,8 @@ public void parseProperties(Properties zkProp)
                     quorumServicePrincipal = value;
                 } else if (key.equals("quorum.cnxn.threads.size")) {
                     quorumCnxnThreadsSize = Integer.parseInt(value);
    +            } else if (key.equals("metricsProvider.className")) {
    --- End diff --
    
    In the case of the server side there is no problem.
    For the client, you can have multiple zk clients in the same jvm.
    It would be better to have a single way of configuring metrics


---

Mime
View raw message