zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle ...
Date Fri, 24 Aug 2018 06:00:21 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/601#discussion_r212527486
  
    --- Diff: src/java/main/org/apache/zookeeper/metrics/impl/NullMetricsProvider.java ---
    @@ -0,0 +1,100 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.zookeeper.metrics.impl;
    +
    +import java.util.Properties;
    +import org.apache.zookeeper.metrics.Counter;
    +import org.apache.zookeeper.metrics.Gauge;
    +import org.apache.zookeeper.metrics.MetricsContext;
    +import org.apache.zookeeper.metrics.MetricsProvider;
    +import org.apache.zookeeper.metrics.MetricsProviderLifeCycleException;
    +import org.apache.zookeeper.metrics.Summary;
    +
    +/**
    + * This is a dummy MetricsProvider which does nothing.
    + */
    +public class NullMetricsProvider implements MetricsProvider {
    --- End diff --
    
    Are we introducing the dummy metric provider to make the code cleaner? Why not check whether
the provider is configured or not, if not we do nothing? 


---

Mime
View raw message