zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper issue #582: ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper ...
Date Mon, 13 Aug 2018 14:15:30 GMT
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/582
  
    Thanks @eolivelli, I got that.
    However, what I'm interested in is slightly different. :)
    
    Let me try to rephrase it:
    I'd like to have an idea of what the different interfaces that you're introducing in this
patch are going to be used for. For example:
    - `MetricsProvider` If I understand it correctly, this is going to be the wrapper of different
metrics providers like Prometheus, Dropwizard, etc.
    - `Counter`/`Gauge`/`Summary` Interfaces for the most commonly used generic metrics behaviours.
    - `MetricsContext` ?? (I have no idea what it is)
    - `MetricsProviderLifeCycleException` Parent exception of all lifecycle exceptions of
a metrics provider.
    
    After all - if my above summary is pretty much correct - the only interface which needs
some clarification is the `MetricsContext`. Also it would be useful to add more context to
its javadoc with some useful examples potentially.
    
    Sorry if you already explained it somewhere else and I just can't find it myself.


---

Mime
View raw message