zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eolivelli <...@git.apache.org>
Subject [GitHub] zookeeper issue #582: ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper ...
Date Fri, 10 Aug 2018 14:02:35 GMT
Github user eolivelli commented on the issue:

    https://github.com/apache/zookeeper/pull/582
  
    @anmolnar  thank you for following up on this.
    
    Background of this issue is on JIRA
    https://issues.apache.org/jira/browse/ZOOKEEPER-3092
    
    the plan is the following:
    - send this patch and discuss the API for a MetricsProvider
    - send a second patch for the boostrap of the MetricsProvider + NOOP implementation +
minimal instrumentation (as an example)
    - send the patch with full instrumentation of all the current metrics exposed in 4LW
    - start the same work on the client
    
    Examples are:
    - Prometheus
    - Dropwizard
    - BookKeeper Stats Loggers API
    - Hadoop Metrics
    
    I can send the second patch if it is worth but I would like to discussion to be as narrow
as possible, a, huge patch won't be reviewable.
    
    At the moment this is the high level API, we will instrument all the code with probes,
starting from all of the current instrumented points.
    
    I think sharing a Google Doc won't help so much, it is better to share code in this particular
case


---

Mime
View raw message