zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From breed <...@git.apache.org>
Subject [GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...
Date Fri, 03 Aug 2018 16:25:16 GMT
Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/588#discussion_r207597400
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
    @@ -1165,6 +1165,58 @@ synchronized public long startForwarding(LearnerHandler handler,
         }
         // VisibleForTesting
         protected final Set<Long> connectingFollowers = new HashSet<Long>();
    +
    +    private volatile boolean quitWaitForEpoch = false;
    +    private volatile long timeStartWaitForEpoch = -1;
    +    private volatile SyncedLearnerTracker voteSet;
    +
    +    public static final String MIN_TIME_WAIT_FOR_EPOCH = "zookeeper.leader.minTimeToWaitForEpoch";
    --- End diff --
    
    should comment this. isn't it really MAX_TIME_TO_WAIT_FOR_EPOCH?


---

Mime
View raw message