zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tamaashu <...@git.apache.org>
Subject [GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...
Date Fri, 03 Aug 2018 11:53:27 GMT
Github user tamaashu commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/587#discussion_r207521296
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java ---
    @@ -39,27 +44,44 @@ public void testMultipleServersChrootPath(){
             String servers = "10.10.10.1,10.10.10.2";
             assertChrootPath(chrootPath,
                     new ConnectStringParser(servers+chrootPath));
    +        
    +        servers = "[2001:db8:1::242:ac11:2]:2181,[2001:db8:85a3:8d3:1319:8a2e:370:7348]:5678";
    --- End diff --
    
    Would be useful to define static strings for the two IPv6 address, since you use them
so often. Less chance to mistype when changing the test.


---

Mime
View raw message