From dev-return-71821-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Jul 26 17:35:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 197A8180621 for ; Thu, 26 Jul 2018 17:35:52 +0200 (CEST) Received: (qmail 49522 invoked by uid 500); 26 Jul 2018 15:35:52 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 49511 invoked by uid 99); 26 Jul 2018 15:35:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jul 2018 15:35:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5D66EDFA6D; Thu, 26 Jul 2018 15:35:51 +0000 (UTC) From: lordofkey To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org Message-ID: Subject: [GitHub] zookeeper pull request #585: Zookeeper 3105:Character coding problem occur w... Content-Type: text/plain Date: Thu, 26 Jul 2018 15:35:51 +0000 (UTC) GitHub user lordofkey opened a pull request: https://github.com/apache/zookeeper/pull/585 Zookeeper 3105:Character coding problem occur when create a node using python3 when creating a node using python3, InvalidACLException occurs all the time. it`s caused by imcompatible way of parsing acl passed through python3 api. so ``` acls->data[i].id.id = strdup( PyUnicode_AsUnicode( PyDict_GetItemString( a, "id" ) ) ); acls->data[i].id.scheme = strdup( PyUnicode_AsUnicode( PyDict_GetItemString( a, "scheme" ) ) ); ``` is changed to ``` acls->data[i].id.id = strdup( PyBytes_AS_STRING( PyUnicode_AsASCIIString( PyDict_GetItemString( a, "id" ) ) ) ); acls->data[i].id.scheme = strdup( PyBytes_AS_STRING( PyUnicode_AsASCIIString( PyDict_GetItemString( a, "scheme" ) ) ) ); ``` because `acls->data[i].id.id` and `acls->data[i].id.scheme` must be an ASCII string. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lordofkey/zookeeper ZOOKEEPER-3105 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/585.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #585 ---- commit e3e68b1d4ffaf1409e74a31eb3365ce20ff956a0 Author: Patrick D. Hunt Date: 2016-03-11T06:34:35Z ZOOKEEPER-2133 zkperl: Segmentation fault if getting a node with null value (Botond Hejj via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1734499 13f79535-47bb-0310-9956-ffa450edef68 commit 3767a3fe7334d2d9aeae31b37442c3bb18ebc7eb Author: Patrick D. Hunt Date: 2016-03-11T06:48:20Z Added some CHANGES details that I missed in recent commits. (phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1734502 13f79535-47bb-0310-9956-ffa450edef68 commit 047936e69ef17b287588a79d0cdedf4d4fd1bffb Author: Patrick D. Hunt Date: 2016-03-14T06:57:10Z ZOOKEEPER-2283 traceFile property is not used in the ZooKeeper, it should be removed from documentation (Arshad Mohammad via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1734882 13f79535-47bb-0310-9956-ffa450edef68 commit a7ceba25e34b61fbfa4efa79283c0d3196998272 Author: Patrick D. Hunt Date: 2016-03-15T16:05:11Z ZOOKEEPER-2385 Zookeeper trunk build is failing on windows (Arshad Mohammad via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1735121 13f79535-47bb-0310-9956-ffa450edef68 commit 8e805005359766c52ef87d964de87696163f1a60 Author: Patrick D. Hunt Date: 2016-03-17T06:14:29Z ZOOKEEPER-2388 Unit tests failing on Solaris (Arshad Mohammad via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1735370 13f79535-47bb-0310-9956-ffa450edef68 commit 0e7e076abbe70a87e31a62d98e21140d6da0a7f5 Author: Patrick D. Hunt Date: 2016-03-18T17:23:04Z ZOOKEEPER-2392 Update netty to 3.7.1.Final (Hendy Irawan via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1735648 13f79535-47bb-0310-9956-ffa450edef68 commit 1b36ea943e209cc76b6930eb90b394958eb19a65 Author: Chris Nauroth Date: 2016-03-19T21:51:14Z ZOOKEEPER-2393: Revert run-time dependency on log4j and slf4j-log4j12 (Arshad Mohammad via cnauroth) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1735822 13f79535-47bb-0310-9956-ffa450edef68 commit 6de6e6c74e9f3492601f1d771f9e248555e47a02 Author: Patrick D. Hunt Date: 2016-03-20T04:28:02Z ZOOKEEPER-2240 Make the three-node minimum more explicit in documentation and on website (Shawn Heisey and Arshad Mohammad via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1735837 13f79535-47bb-0310-9956-ffa450edef68 commit adcf1469a0851b09a3bd92a9657c9a49efb4ce68 Author: Patrick D. Hunt Date: 2016-03-20T18:34:57Z ZOOKEEPER-2195 fsync.warningthresholdms in zoo.cfg not working (Biju Nair via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1735893 13f79535-47bb-0310-9956-ffa450edef68 commit 8d8090f3274733db90e55c9412294ae02095ec4d Author: Chris Nauroth Date: 2016-03-21T20:45:37Z ZOOKEEPER-2364: "ant docs" fails on branch-3.5 due to missing releasenotes.xml. (phunt via cnauroth) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1736093 13f79535-47bb-0310-9956-ffa450edef68 commit f2c863e8b026109732bf19d662ee91956f05ab5b Author: Camille Fournier Date: 2016-03-22T23:36:42Z ZOOKEEPER-2141. ACL cache in DataTree never removes entries (Adam Milne-Smith via camille) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1736260 13f79535-47bb-0310-9956-ffa450edef68 commit e43a0bb6466a7864c4356c5b844a72142a30a667 Author: Camille Fournier Date: 2016-04-06T18:04:48Z ZOOKEEPER-2141 ACL cache in DataTree never removes entries (Adam Milne-Smith via camille) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1738011 13f79535-47bb-0310-9956-ffa450edef68 commit ac6c61eb050a527f543ab83caca2e155e5a608bc Author: Flavio Paiva Junqueira Date: 2016-04-24T21:19:55Z ZOOKEEPER-2413: ContainerManager doesn't close the Timer it creates when stop() is called (Jordan via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1740737 13f79535-47bb-0310-9956-ffa450edef68 commit b93f88527124246ad19002264661741abb1eaac0 Author: Flavio Paiva Junqueira Date: 2016-05-02T16:18:22Z ZOOKEEPER-2139: Support multiple ZooKeeper client with different configurations in a single JVM (Arshad Mohammad via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1742003 13f79535-47bb-0310-9956-ffa450edef68 commit 70decf6bbd087e8b761974014b4ae7fb1b7cd6ce Author: Patrick D. Hunt Date: 2016-05-03T18:27:43Z ZOOKEEPER-2235 License update - fix servlet-api license (fpj via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1742172 13f79535-47bb-0310-9956-ffa450edef68 commit e29b1599cc31f84b8f2198ce5b0afeea2d16a923 Author: Patrick D. Hunt Date: 2016-05-05T20:52:23Z ZOOKEEPER-2423: Upgrade Netty version due to security vulnerability (CVE-2014-3488) (Michael Han via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1742473 13f79535-47bb-0310-9956-ffa450edef68 commit eab2182aa07aa635d4a56878df5d0ef9367f501a Author: Flavio Paiva Junqueira Date: 2016-05-23T21:32:58Z ZOOKEEPER-2402: Document client side properties (Arshad Mohammad via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1745280 13f79535-47bb-0310-9956-ffa450edef68 commit 10d7c32f3903e6099031e3d779c64cfec983bc51 Author: Patrick D. Hunt Date: 2016-05-25T20:45:11Z ZOOKEEPER-2405: getTGT() in Login.java mishandles confidential information (Michael Han via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1745536 13f79535-47bb-0310-9956-ffa450edef68 commit 32212def83d966f874abb76c25ca01e5bc96c34f Author: Patrick D. Hunt Date: 2016-06-01T23:00:54Z ZOOKEEPER-2410: add time unit to 'ELECTION TOOK' log.info message (Christine Poerschke via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1746512 13f79535-47bb-0310-9956-ffa450edef68 commit 1285797e2b369b7796622fbdee704987ce24df39 Author: Patrick D. Hunt Date: 2016-06-15T17:15:07Z ZOOKEEPER-2137: Make testPortChange() less flaky (Michael Han via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1748610 13f79535-47bb-0310-9956-ffa450edef68 commit 84a89f3d5bb822ded7c64bc992886679f74afb0a Author: Patrick D. Hunt Date: 2016-06-15T20:31:24Z ZOOKEEPER-2433: ZooKeeperSaslServer: allow user principals in subject (Andy B via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1748631 13f79535-47bb-0310-9956-ffa450edef68 commit 98a03c76a074fe4225a1e7d9c7a7850312b9f563 Author: Flavio Paiva Junqueira Date: 2016-06-23T17:41:36Z ZOOKEEPER-2297: NPE is thrown while creating "key manager" and "trust manager" (Arshad Mohammad via fpj) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1749950 13f79535-47bb-0310-9956-ffa450edef68 commit 82bdfe28209dc06f9548f0575e35c9f02ebe7b99 Author: Chris Nauroth Date: 2016-06-23T21:19:00Z ZOOKEEPER-2380: Deadlock between leader shutdown and forwarding ACK to the leader. (Arshad Mohammad via cnauroth) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1750021 13f79535-47bb-0310-9956-ffa450edef68 commit 87e8e64b95e56c31feb242277fbe3dca88a75738 Author: Chris Nauroth Date: 2016-06-23T21:45:50Z ZOOKEEPER-2366: Reconfiguration of client port causes a socket leak. (fpj via cnauroth) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1750026 13f79535-47bb-0310-9956-ffa450edef68 commit 933b4fedf998043dc73abb6bd550b9e23f0df918 Author: Chris Nauroth Date: 2016-06-23T22:23:46Z Preparing for release 3.5.2-alpha. git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1750030 13f79535-47bb-0310-9956-ffa450edef68 commit a121e3847eef3a235735935b0145953861d7f644 Author: Patrick D. Hunt Date: 2016-06-30T03:55:39Z ZOOKEEPER-2458: Remove license file for servlet-api dependency (fpj via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1750738 13f79535-47bb-0310-9956-ffa450edef68 commit e6f4ad118322ee384fd2cb195e078ea7efadfbbf Author: Patrick D. Hunt Date: 2016-06-30T04:12:16Z ZOOKEEPER-2459: Update NOTICE file with Netty notice (fpj via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1750740 13f79535-47bb-0310-9956-ffa450edef68 commit 4c40a40c30fbb76223b1f13e2bfe5790edced89b Author: Chris Nauroth Date: 2016-06-30T05:35:14Z Preparing for release 3.5.2-alpha RC1 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1750744 13f79535-47bb-0310-9956-ffa450edef68 commit 632438c8a302e37f8a528a69961de1836b06d714 Author: Chris Nauroth Date: 2016-07-20T18:09:37Z Prepare for 3.5.3-alpha development. git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1753589 13f79535-47bb-0310-9956-ffa450edef68 commit 4a9d94db8084249dce564561fec5d682077a3023 Author: Patrick D. Hunt Date: 2016-07-26T23:35:27Z ZOOKEEPER-1898: ZooKeeper Java cli shell always returns 0 as exit code (Abraham Fine via phunt) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1754189 13f79535-47bb-0310-9956-ffa450edef68 ---- ---