From dev-return-71067-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Jul 3 22:36:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 13178180632 for ; Tue, 3 Jul 2018 22:36:54 +0200 (CEST) Received: (qmail 97840 invoked by uid 500); 3 Jul 2018 20:36:54 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 97823 invoked by uid 99); 3 Jul 2018 20:36:53 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jul 2018 20:36:53 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E3F9CE049E; Tue, 3 Jul 2018 20:36:52 +0000 (UTC) From: sl4mmy To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org Message-ID: Subject: [GitHub] zookeeper pull request #558: ZOOKEEPER-3078: remove print_completion_queue Content-Type: text/plain Date: Tue, 3 Jul 2018 20:36:52 +0000 (UTC) GitHub user sl4mmy opened a pull request: https://github.com/apache/zookeeper/pull/558 ZOOKEEPER-3078: remove print_completion_queue The fprintf(LOGSTREAM, ...) calls cause compiler errors when building with GCC 8: "error: null argument where non-null required". This is because since ZOOKEEPER-1400 (2013-05-19 commit 37973fab: Allow logging via callback instead of raw FILE pointer) LOGSTREAM is defined as NULL. However, the last use of print_completion_queue was removed 2008-01-10 in commit ffc4b0d4 (Changed zoo_get() signature, changed the watcher callback signature, fixed zookeeper_close() resource leaks and race conditions, fixed the race condition causing xid mismatch). So we can avoid the compiler errors by just removing print_completion_queue. Signed-off-by: Kent R. Spillner You can merge this pull request into a Git repository by running: $ git pull https://github.com/sl4mmy/zookeeper zookeeper-3078 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/558.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #558 ---- commit 9e15acb59fe9fb1113d9e9b5f3321aac7bac8292 Author: Kent R. Spillner Date: 2018-07-03T20:18:25Z ZOOKEEPER-3078: remove print_completion_queue The fprintf(LOGSTREAM, ...) calls cause compiler errors when building with GCC 8: "error: null argument where non-null required". This is because since ZOOKEEPER-1400 (2013-05-19 commit 37973fab: Allow logging via callback instead of raw FILE pointer) LOGSTREAM is defined as NULL. However, the last use of print_completion_queue was removed 2008-01-10 in commit ffc4b0d4 (Changed zoo_get() signature, changed the watcher callback signature, fixed zookeeper_close() resource leaks and race conditions, fixed the race condition causing xid mismatch). So we can avoid the compiler errors by just removing print_completion_queue. Signed-off-by: Kent R. Spillner ---- ---