From dev-return-71125-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Jul 4 17:13:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6B9C3180608 for ; Wed, 4 Jul 2018 17:13:03 +0200 (CEST) Received: (qmail 13778 invoked by uid 500); 4 Jul 2018 15:13:02 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 13767 invoked by uid 99); 4 Jul 2018 15:13:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jul 2018 15:13:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0CA21C2E9E for ; Wed, 4 Jul 2018 15:13:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id yHcVcjzoOfyN for ; Wed, 4 Jul 2018 15:13:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 25DC45F431 for ; Wed, 4 Jul 2018 15:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B33ABE0110 for ; Wed, 4 Jul 2018 15:13:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6CE7D27509 for ; Wed, 4 Jul 2018 15:13:00 +0000 (UTC) Date: Wed, 4 Jul 2018 15:13:00 +0000 (UTC) From: "Andor Molnar (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ZOOKEEPER-2873) print error and/or abort on invalid server definition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-2873. ------------------------------------- Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue resolved by pull request 549 [https://github.com/apache/zookeeper/pull/549] > print error and/or abort on invalid server definition > ----------------------------------------------------- > > Key: ZOOKEEPER-2873 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.4.10 > Reporter: Christopher Smith > Assignee: Norbert Kalmar > Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > While bringing up a new cluster, I managed to fat-finger a sed script and put some lines like this into my config file: > {code} > server.1=zookeeper1:2888:2888 > {code} > This led to a predictable spew of error messages when the client and election components fought over the single port. Since a configuration of this case is *always* an error, I suggest that it would be sensible to abort the server startup if an entry is found with the same port for both client and election. (Logging the error explicitly without shutting down is less helpful because of how fast the logs pile up.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)