From dev-return-71931-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Jul 28 02:10:45 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5E68D180657 for ; Sat, 28 Jul 2018 02:10:44 +0200 (CEST) Received: (qmail 75838 invoked by uid 500); 28 Jul 2018 00:10:43 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 75826 invoked by uid 99); 28 Jul 2018 00:10:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Jul 2018 00:10:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 83FF7DFAD2; Sat, 28 Jul 2018 00:10:42 +0000 (UTC) From: lvfangmin To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #579: [ZOOKEEPER-3095] Connect string fix for non-exi... Content-Type: text/plain Message-Id: <20180728001042.83FF7DFAD2@git1-us-west.apache.org> Date: Sat, 28 Jul 2018 00:10:42 +0000 (UTC) Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/579#discussion_r205924496 --- Diff: src/c/tests/zkServer.sh --- @@ -77,7 +77,7 @@ fi if [ "x${base_dir}" == "x" ] then -zk_base="../../" +zk_base="../../../" --- End diff -- Yes, seems the old code is not working if the base_dir is not specified. We were using this to test the change manually, so it's related from testing purpose. ---