From dev-return-71816-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Jul 26 08:12:19 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 37AF318067C for ; Thu, 26 Jul 2018 08:12:19 +0200 (CEST) Received: (qmail 61492 invoked by uid 500); 26 Jul 2018 06:12:17 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 60656 invoked by uid 99); 26 Jul 2018 06:12:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jul 2018 06:12:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 131EDDFF73; Thu, 26 Jul 2018 06:12:16 +0000 (UTC) From: hanm To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency... Content-Type: text/plain Message-Id: <20180726061216.131EDDFF73@git1-us-west.apache.org> Date: Thu, 26 Jul 2018 06:12:16 +0000 (UTC) Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/447#discussion_r205332227 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java --- @@ -19,6 +19,8 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; +import java.util.Set; +import java.util.HashSet; --- End diff -- Are both imports needed? I don't see any new data structure introduced. ---