From dev-return-71777-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Jul 25 07:24:37 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 98B5D18062C for ; Wed, 25 Jul 2018 07:24:36 +0200 (CEST) Received: (qmail 68715 invoked by uid 500); 25 Jul 2018 05:24:35 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 68701 invoked by uid 99); 25 Jul 2018 05:24:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jul 2018 05:24:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6EF43DFBC7; Wed, 25 Jul 2018 05:24:34 +0000 (UTC) From: hanm To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ... Content-Type: text/plain Message-Id: <20180725052434.6EF43DFBC7@git1-us-west.apache.org> Date: Wed, 25 Jul 2018 05:24:34 +0000 (UTC) Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r204984357 --- Diff: src/java/main/org/apache/zookeeper/client/ZKClientConfig.java --- @@ -56,9 +56,15 @@ @SuppressWarnings("deprecation") public static final String SECURE_CLIENT = ZooKeeper.SECURE_CLIENT; public static final int CLIENT_MAX_PACKET_LENGTH_DEFAULT = 4096 * 1024; /* 4 MB */ + public static final String ZOOKEEPER_REQUEST_TIMEOUT = "zookeeper.request.timeout"; + /** + * Feature is disabled by default. --- End diff -- I tend to learn towards the conservative side to have this feature turned off by default, because I feel we don't have deep insight regarding what's the value we could use as default value (if we turn the feature on by default), and a premature setting of that value might impact existing users. For few of users who do have the problem they can tune the parameter based on their prod env. ---