From dev-return-71394-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Jul 13 13:05:40 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9052E180626 for ; Fri, 13 Jul 2018 13:05:39 +0200 (CEST) Received: (qmail 62197 invoked by uid 500); 13 Jul 2018 11:05:38 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 62185 invoked by uid 99); 13 Jul 2018 11:05:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2018 11:05:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9B20ADFAD2; Fri, 13 Jul 2018 11:05:37 +0000 (UTC) From: maoling To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #553: continue can be replaced with break Content-Type: text/plain Message-Id: <20180713110537.9B20ADFAD2@git1-us-west.apache.org> Date: Fri, 13 Jul 2018 11:05:37 +0000 (UTC) Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/553 @a470577391 it's useful and enough to change `continue` to `break`,especially when call `getLogFiles(logDir.listFiles(), 0)` It's better to create a [JIRA](https://issues.apache.org/jira/projects/ZOOKEEPER/) issues (sign up JIRA if you don't have an account) to bind this PR to a JIRA-ID The contributor guide is [here](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute]) ---