From dev-return-71389-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Fri Jul 13 08:12:41 2018
Return-Path: <dev-return-71389-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 93C85180626
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 13 Jul 2018 08:12:40 +0200 (CEST)
Received: (qmail 3082 invoked by uid 500); 13 Jul 2018 06:12:39 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 3071 invoked by uid 99); 13 Jul 2018 06:12:38 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2018 06:12:38 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 511D1DFAD2; Fri, 13 Jul 2018 06:12:38 +0000 (UTC)
From: jpeach <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-565-zookeeper@git.apache.org>
In-Reply-To: <git-pr-565-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper issue #565: ZOOKEEPER-3067: Optionally disable client environment ...
Content-Type: text/plain
Message-Id: <20180713061238.511D1DFAD2@git1-us-west.apache.org>
Date: Fri, 13 Jul 2018 06:12:38 +0000 (UTC)

Github user jpeach commented on the issue:

    https://github.com/apache/zookeeper/pull/565
  
    Added a test. I needed the following patch to get the tests to build on Fedora 28:
    ```
    diff --git a/src/c/Makefile.am b/src/c/Makefile.am
    index a81e3da2..0230419b 100644
    --- a/src/c/Makefile.am
    +++ b/src/c/Makefile.am
    @@ -120,14 +120,14 @@ check_PROGRAMS = zktest-st
     TESTS_ENVIRONMENT = ZKROOT=${srcdir}/../.. \
                         CLASSPATH=$$CLASSPATH:$$CLOVER_HOME/lib/clover.jar
     nodist_zktest_st_SOURCES = $(TEST_SOURCES)
    -zktest_st_LDADD = libzkst.la libhashtable.la $(CPPUNIT_LIBS)
    +zktest_st_LDADD = libzkst.la libhashtable.la $(CPPUNIT_LIBS) -ldl
     zktest_st_CXXFLAGS = -DUSE_STATIC_LIB $(CPPUNIT_CFLAGS) $(USEIPV6) $(SOLARIS_CPPFLAGS)
     zktest_st_LDFLAGS = -shared $(SYMBOL_WRAPPERS) $(SOLARIS_LIB_LDFLAGS)
    
     if WANT_SYNCAPI
       check_PROGRAMS += zktest-mt
       nodist_zktest_mt_SOURCES = $(TEST_SOURCES) tests/PthreadMocks.cc
    -  zktest_mt_LDADD = libzkmt.la libhashtable.la -lpthread $(CPPUNIT_LIBS)
    +  zktest_mt_LDADD = libzkmt.la libhashtable.la -lpthread $(CPPUNIT_LIBS) -ldl
       zktest_mt_CXXFLAGS = -DUSE_STATIC_LIB -DTHREADED $(CPPUNIT_CFLAGS) $(USEIPV6)
     if SOLARIS
       SHELL_SYMBOL_WRAPPERS_MT = cat ${srcdir}/tests/wrappers-mt.opt
    diff --git a/src/c/configure.ac b/src/c/configure.ac
    index 9811618d..e905aa4d 100644
    --- a/src/c/configure.ac
    +++ b/src/c/configure.ac
    @@ -34,7 +34,7 @@ if test "$with_cppunit" = "no" ; then
        CPPUNIT_INCLUDE=
        CPPUNIT_LIBS=
     else
    -   AM_PATH_CPPUNIT(1.10.2)
    +   PKG_CHECK_MODULES([CPPUNIT], [cppunit], [HAVE_CPPUNIT=yes])
     fi
    
     if test "$CALLER" = "ANT" ; then
    @@ -52,6 +52,7 @@ AM_PROG_CC_C_O
     AC_PROG_CXX
     AC_PROG_INSTALL
     AC_PROG_LN_S
    +AM_PROG_AR
    
     # AC_DISABLE_SHARED
     AC_PROG_LIBTOOL
    ```


---