From dev-return-71324-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Jul 11 01:36:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 10E67180634 for ; Wed, 11 Jul 2018 01:36:57 +0200 (CEST) Received: (qmail 67174 invoked by uid 500); 10 Jul 2018 23:36:52 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 67163 invoked by uid 99); 10 Jul 2018 23:36:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jul 2018 23:36:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5F0EADFA6D; Tue, 10 Jul 2018 23:36:51 +0000 (UTC) From: hanm To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy... Content-Type: text/plain Message-Id: <20180710233651.5F0EADFA6D@git1-us-west.apache.org> Date: Tue, 10 Jul 2018 23:36:51 +0000 (UTC) Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/561#discussion_r201527825 --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java --- @@ -817,10 +817,12 @@ protected void pRequest(Request request) throws RequestProcessorException { type = OpCode.error; txn = new ErrorTxn(e.code().intValue()); - LOG.info("Got user-level KeeperException when processing " - + request.toString() + " aborting remaining multi ops." - + " Error Path:" + e.getPath() - + " Error:" + e.getMessage()); + if (e.code().intValue() > Code.APIERROR.intValue()) { --- End diff -- I get the point - things will break when they are running at scale :) . I don't have strong opinion holding this as INFO. wondering how others think about this (I mentioned it's info as this log was my good friend before when I debugged some issues...). BTW for similar use case (large scale of clients) - it looks like all client side related log should be silenced on server side. basically server side just keep server specific loggings on by default (which hopefully does not change regardless of the scale of clients). So all client cnx / session related logs need be silenced... ---