From dev-return-71216-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Jul 9 14:44:38 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D9F4F18062A for ; Mon, 9 Jul 2018 14:44:37 +0200 (CEST) Received: (qmail 29243 invoked by uid 500); 9 Jul 2018 12:44:36 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 28459 invoked by uid 99); 9 Jul 2018 12:44:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jul 2018 12:44:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2C62EDFB34; Mon, 9 Jul 2018 12:44:35 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy... Content-Type: text/plain Message-Id: <20180709124435.2C62EDFB34@git1-us-west.apache.org> Date: Mon, 9 Jul 2018 12:44:35 +0000 (UTC) Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/561#discussion_r200987742 --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java --- @@ -817,10 +817,12 @@ protected void pRequest(Request request) throws RequestProcessorException { type = OpCode.error; txn = new ErrorTxn(e.code().intValue()); - LOG.info("Got user-level KeeperException when processing " - + request.toString() + " aborting remaining multi ops." - + " Error Path:" + e.getPath() - + " Error:" + e.getMessage()); + if (e.code().intValue() > Code.APIERROR.intValue()) { --- End diff -- Additionally refactoring this one to use message formatter would be nice. ---