zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sl4mmy <...@git.apache.org>
Subject [GitHub] zookeeper pull request #558: ZOOKEEPER-3078: remove print_completion_queue
Date Tue, 03 Jul 2018 20:36:52 GMT
GitHub user sl4mmy opened a pull request:

    https://github.com/apache/zookeeper/pull/558

    ZOOKEEPER-3078: remove print_completion_queue

    The fprintf(LOGSTREAM, ...) calls cause compiler errors when building
    with GCC 8: "error: null argument where non-null required".  This is
    because since ZOOKEEPER-1400 (2013-05-19 commit 37973fab: Allow logging
    via callback instead of raw FILE pointer) LOGSTREAM is defined as NULL.
    However, the last use of print_completion_queue was removed 2008-01-10
    in commit ffc4b0d4 (Changed zoo_get() signature, changed the watcher
    callback signature, fixed zookeeper_close() resource leaks and race
    conditions, fixed the race condition causing xid mismatch).  So we can
    avoid the compiler errors by just removing print_completion_queue.
    
    Signed-off-by: Kent R. Spillner <kspillner@acm.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sl4mmy/zookeeper zookeeper-3078

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #558
    
----
commit 9e15acb59fe9fb1113d9e9b5f3321aac7bac8292
Author: Kent R. Spillner <kspillner@...>
Date:   2018-07-03T20:18:25Z

    ZOOKEEPER-3078: remove print_completion_queue
    
    The fprintf(LOGSTREAM, ...) calls cause compiler errors when building
    with GCC 8: "error: null argument where non-null required".  This is
    because since ZOOKEEPER-1400 (2013-05-19 commit 37973fab: Allow logging
    via callback instead of raw FILE pointer) LOGSTREAM is defined as NULL.
    However, the last use of print_completion_queue was removed 2008-01-10
    in commit ffc4b0d4 (Changed zoo_get() signature, changed the watcher
    callback signature, fixed zookeeper_close() resource leaks and race
    conditions, fixed the race condition causing xid mismatch).  So we can
    avoid the compiler errors by just removing print_completion_queue.
    
    Signed-off-by: Kent R. Spillner <kspillner@acm.org>

----


---

Mime
View raw message