zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Han (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3092) Pluggable metrics system for ZooKeeper
Date Wed, 18 Jul 2018 18:16:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548197#comment-16548197
] 

Michael Han commented on ZOOKEEPER-3092:
----------------------------------------

[~eolivelli] I think this work does not depend on the ongoing maven work, and we should treat
the metric system interfaces as part of ZooKeeper instead of using external ones, for the
same reason Robert mentioned, so we can have full control over it which would give us more
flexibilities over what we want to add / remove down the road. Please let me know if you have
any concerns of this approach (and I am also interested on hearing what others think).

Yes designing the metrics API is the first step. It does not have to be perfect, and have
everything other metric systems already have, and we can started from typical metrics types
and a reporting interface. I am thinking we can use org.apache.zookeeper.metrics as namespace.
Once the first version of interfaces are defined, we could provide a set of default implementations.
Then we can proceed to implement the feature of dynamically load an external metrics reporting
library. And some testings of course along the way. Sounds a lot of work, but should be fun
:). 

It's up to you how you want to do the design work - a short design doc or a pull request for
the proposed interfaces, either would work. Also it's likely we should use this Jira as an
umbrella and create actual tasks under it so this feature can be shipped incrementally.

 

> Pluggable metrics system for ZooKeeper
> --------------------------------------
>
>                 Key: ZOOKEEPER-3092
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3092
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: metric system
>            Reporter: Michael Han
>            Priority: Major
>
> ZooKeeper should provide a pluggable metrics system such that various metrics can be
collected and reported using different approaches that fit production monitoring / alert /
debugging needs. 
> Historically ZooKeeper provides four letter words and JMX which exposes certain stats
/ metrics but they are not very flexible in terms of programmatically accessing metrics and
connecting metrics to different reporting systems.
> There are other projects that's already doing this which can be used for reference, such
as bookkeeper metrics service providers and hadoop metrics2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message