zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nkalmar <...@git.apache.org>
Subject [GitHub] zookeeper issue #572: ZOOKEEPER-3085 define exit codes in enum
Date Mon, 30 Jul 2018 14:38:11 GMT
Github user nkalmar commented on the issue:

    https://github.com/apache/zookeeper/pull/572
  
    @pravsingh , I changed the comments to javadoc comments. But after creating the tests,
it was kind of strange. I looked at other enum in ZK, we don't check the values. I think we
will see in a PR if someone wants to change the enum's value. (And if someone wants to change
it, he might as easily change the tests too). 
    
    Bottom line, I don't think it is necessary to have a unit test to check ExitCode values.

    What do others think? 


---

Mime
View raw message