zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #579: [ZOOKEEPER-3095] Connect string fix for non-exi...
Date Sat, 28 Jul 2018 00:10:42 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/579#discussion_r205924496
  
    --- Diff: src/c/tests/zkServer.sh ---
    @@ -77,7 +77,7 @@ fi
     
     if [ "x${base_dir}" == "x" ]
     then
    -zk_base="../../"
    +zk_base="../../../"
    --- End diff --
    
    Yes, seems the old code is not working if the base_dir is not specified. 
    
    We were using this to test the change manually, so it's related from testing purpose.



---

Mime
View raw message