zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency...
Date Fri, 27 Jul 2018 23:45:03 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/447#discussion_r205922455
  
    --- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java ---
    @@ -280,6 +275,11 @@ public synchronized boolean addSession(long id, int sessionTimeout)
{
             return added;
         }
     
    +    public synchronized boolean commitSession(long id, int sessionTimeout) {
    +        sessionsWithTimeout.put(id, sessionTimeout);
    +        return true;
    --- End diff --
    
    The LeaderSessionTracker.commitSession will return whether it has successfully added the
new session.


---

Mime
View raw message