zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency...
Date Fri, 27 Jul 2018 23:42:13 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/447#discussion_r205920948
  
    --- Diff: src/java/test/org/apache/zookeeper/test/QuorumBase.java ---
    @@ -53,32 +53,32 @@
         protected int port3;
         protected int port4;
         protected int port5;
    -    
    +
         protected int portLE1;
         protected int portLE2;
         protected int portLE3;
         protected int portLE4;
         protected int portLE5;
    -    
    +
         protected int portClient1;
         protected int portClient2;
         protected int portClient3;
         protected int portClient4;
         protected int portClient5;
     
    -    protected boolean localSessionsEnabled = false;
    -    protected boolean localSessionsUpgradingEnabled = false;
    +    public boolean localSessionsEnabled = false;
    +    public boolean localSessionsUpgradingEnabled = false;
    --- End diff --
    
    Same reason, will check and remove it if it's not required.


---

Mime
View raw message