zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pravsingh <...@git.apache.org>
Subject [GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...
Date Fri, 27 Jul 2018 21:31:42 GMT
Github user pravsingh commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/496#discussion_r205904126
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java
---
    @@ -66,8 +67,8 @@ public SaslQuorumAuthLearner(boolean quorumRequireSasl,
                                              + "section '" + loginContext
                                              + "' could not be found.");
                 }
    -            this.learnerLogin = new Login(loginContext,
    -                                    new SaslClientCallbackHandler(null, "QuorumLearner"),
new ZKConfig());
    +            this.learnerLogin = loginFactory.createLogin(loginContext,
    +                    new SaslClientCallbackHandler(null, "QuorumLearner"), new ZKConfig());
    --- End diff --
    
    this can be put on above line. makes it more readable.


---

Mime
View raw message