zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pravsingh <...@git.apache.org>
Subject [GitHub] zookeeper pull request #572: ZOOKEEPER-3085 define exit codes in enum
Date Fri, 27 Jul 2018 21:20:25 GMT
Github user pravsingh commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/572#discussion_r205901511
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ExitCode.java ---
    @@ -20,8 +20,35 @@
     /**
      * Exit code used to exit server
      */
    -public class ExitCode {
    +public enum ExitCode {
    +
    +    /* Execution finished normally */
    --- End diff --
    
    I would suggest using java doc comment. /**....*/.


---

Mime
View raw message