zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper issue #584: ZOOKEEPER-3102: Potential race condition when create e...
Date Fri, 27 Jul 2018 05:40:04 GMT
Github user lvfangmin commented on the issue:

    https://github.com/apache/zookeeper/pull/584
  
    This is good enough to make the ephemerals thread safe in DataTree, if it's being called
in multiple thread, the code you touched here may add ephemerals which is just removed in
killSession.
    
    A lot of code inside DataTree assumes that there is a single thread will call it, and
it's guaranteed from FinalRequestProcessor, which is called from the WorkerService in CommitProcessor,
and CommitProcessor guarantees only a single write is allowed at a time. So I agree with Ben,
I don't think we need this change.


---

Mime
View raw message