zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From breed <...@git.apache.org>
Subject [GitHub] zookeeper pull request #555: ZOOKEEPER-3061: add more details to 'Unhandled ...
Date Fri, 27 Jul 2018 05:16:29 GMT
Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/555#discussion_r205669958
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
    @@ -792,7 +792,14 @@ public boolean syncFollower(long peerLastZxid, ZKDatabase db, Leader
leader) {
                         txnProposalItr.close();
                     }
                 } else {
    -                LOG.warn("Unhandled scenario for peer sid: " +  getSid());
    +                LOG.warn("Unhandled scenario for peer sid: {} maxCommittedLog=0x{}"
    --- End diff --
    
    the logging levels are different, and it is nice to have the evaluation information with
weird corner case scenario. i think it's worth surfacing the information here as well.


---

Mime
View raw message