zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From breed <...@git.apache.org>
Subject [GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...
Date Fri, 27 Jul 2018 04:50:06 GMT
Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/567#discussion_r205667305
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -102,6 +102,20 @@
         /** Maximum time we allow for elapsed fsync before WARNing */
         private final static long fsyncWarningThresholdMS;
     
    +    /**
    +     * This parameter limit the size of each txnlog to a given limit (KB).
    +     * It does not affect how often the system will take a snapshot
    +     * [zookeeper.snapCount]
    +     *
    +     * The feature is disabled by default (-1)
    +     */
    +    public static final String LOG_SIZE_LIMIT = "zookeeper.txnlogSizeLimit";
    +
    +    /**
    +     * The actual txnlog size limit in bytes.
    +     */
    +    public static long logSizeLimit = -1;
    +
    --- End diff --
    
    good points @maoling ! is there a reason these two variables should be public? it would
be nice to make the variable have a similar name to the property.


---

Mime
View raw message