zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From breed <...@git.apache.org>
Subject [GitHub] zookeeper pull request #545: ZOOKEEPER-2261 When only secureClientPort is co...
Date Fri, 27 Jul 2018 04:11:08 GMT
Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/545#discussion_r205663822
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -866,6 +866,9 @@ public void setServerCnxnFactory(ServerCnxnFactory factory) {
         }
     
         public ServerCnxnFactory getServerCnxnFactory() {
    +        if (secureServerCnxnFactory != null) {
    +            return secureServerCnxnFactory;
    +        }
             return serverCnxnFactory;
         }
     
    --- End diff --
    
    i don't feel strongly about it, but i like @hanm 's idea.


---

Mime
View raw message