zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maoling <...@git.apache.org>
Subject [GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...
Date Thu, 26 Jul 2018 16:55:44 GMT
Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/567#discussion_r205527457
  
    --- Diff: src/java/test/org/apache/zookeeper/test/TxnLogSizeLimitTest.java ---
    @@ -0,0 +1,173 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.test;
    +
    +import java.io.File;
    +import java.util.HashSet;
    +import java.util.Random;
    +
    +import org.apache.log4j.Logger;
    +import org.apache.zookeeper.CreateMode;
    +import org.apache.zookeeper.PortAssignment;
    +import org.apache.zookeeper.WatchedEvent;
    +import org.apache.zookeeper.Watcher;
    +import org.apache.zookeeper.ZKTestCase;
    +import org.apache.zookeeper.ZooDefs.Ids;
    +import org.apache.zookeeper.ZooKeeper;
    +import org.apache.zookeeper.data.Stat;
    +import org.apache.zookeeper.proto.CreateRequest;
    +import org.apache.zookeeper.server.ServerCnxnFactory;
    +import org.apache.zookeeper.server.ZKDatabase;
    +import org.apache.zookeeper.server.ZooKeeperServer;
    +import org.apache.zookeeper.server.persistence.FileTxnLog;
    +import org.apache.zookeeper.server.persistence.FileTxnSnapLog;
    +import org.apache.zookeeper.txn.TxnHeader;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +/**
    + * Test loading committed proposal from txnlog. Learner uses these proposals to
    + * catch-up with leader
    + */
    +public class TxnLogSizeLimitTest extends ZKTestCase implements Watcher {
    +    private static final Logger LOG = Logger
    --- End diff --
    
    the unit tests in the `TxnLogSizeLimitTest` can be moved to `FileTxnLogTest`?


---

Mime
View raw message