zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...
Date Wed, 25 Jul 2018 05:24:34 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/119#discussion_r204984357
  
    --- Diff: src/java/main/org/apache/zookeeper/client/ZKClientConfig.java ---
    @@ -56,9 +56,15 @@
         @SuppressWarnings("deprecation")
         public static final String SECURE_CLIENT = ZooKeeper.SECURE_CLIENT;
         public static final int CLIENT_MAX_PACKET_LENGTH_DEFAULT = 4096 * 1024; /* 4 MB */
    +    public static final String ZOOKEEPER_REQUEST_TIMEOUT = "zookeeper.request.timeout";
    +    /**
    +     * Feature is disabled by default.
    --- End diff --
    
    I tend to learn towards the conservative side to have this feature turned off by default,
because I feel we don't have deep insight regarding what's the value we could use as default
value (if we turn the feature on by default), and a premature setting of that value might
impact existing users. For few of users who do have the problem they can tune the parameter
based on their prod env. 


---

Mime
View raw message