zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eolivelli <...@git.apache.org>
Subject [GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...
Date Tue, 24 Jul 2018 05:41:56 GMT
Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/119#discussion_r204628644
  
    --- Diff: src/java/test/org/apache/zookeeper/ClientResponseTimeoutTest.java ---
    @@ -0,0 +1,165 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper;
    +
    +import static org.apache.zookeeper.test.ClientBase.CONNECTION_TIMEOUT;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.fail;
    +
    +import java.io.IOException;
    +
    +import org.apache.zookeeper.ZooDefs.Ids;
    +import org.apache.zookeeper.client.HostProvider;
    +import org.apache.zookeeper.server.quorum.QuorumPeerTestBase;
    +import org.apache.zookeeper.test.ClientBase;
    +import org.apache.zookeeper.test.ClientBase.CountdownWatcher;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +public class ClientResponseTimeoutTest extends QuorumPeerTestBase {
    --- End diff --
    
    Not sure we need to start a full cluster, what about adding a bunch of  mockito based
tests?
    
    I think that having a test which uses the full stack may have some value, so maybe we
can keep this. But in case of failure we are not sure about the real cause


---

Mime
View raw message