zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #566: ZOOKEEPER-3062: mention fsync.warningthresholdm...
Date Sat, 14 Jul 2018 06:46:35 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/566#discussion_r202508017
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -339,7 +342,8 @@ public synchronized void commit() throws IOException {
                                 + Thread.currentThread().getName()
                                 + " took " + syncElapsedMS
                                 + "ms which will adversely effect operation latency. "
    -                            + "File size is " + channel.size() + " bytes. "
    +                            + "File size is " + channel.size() + " bytes and "
    --- End diff --
    
    It's cleaner to change the logger format to using placeholder with {}.


---

Mime
View raw message