zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...
Date Fri, 13 Jul 2018 14:41:39 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/567#discussion_r202362761
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -110,6 +124,18 @@
             if ((fsyncWarningThreshold = Long.getLong("zookeeper.fsync.warningthresholdms"))
== null)
                 fsyncWarningThreshold = Long.getLong("fsync.warningthresholdms", 1000);
             fsyncWarningThresholdMS = fsyncWarningThreshold;
    +
    +        Long logSize = Long.getLong(LOG_SIZE_LIMIT, -1);
    +        if (logSize > 0) {
    +            // Convert to bytes
    +            logSize = logSize * 1024;
    +            if (logSize <= preAllocSize) {
    +                LOG.error("Ignoring invalid txn log size limit (lesser than preAllocSize)");
    --- End diff --
    
    language: "less than ..."


---

Mime
View raw message