zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maoling <...@git.apache.org>
Subject [GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage
Date Thu, 12 Jul 2018 06:55:15 GMT
Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/548#discussion_r201901490
  
    --- Diff: src/java/test/org/apache/zookeeper/server/util/ConfigUtilsTest.java ---
    @@ -29,4 +30,21 @@ public void testSplitServerConfig() throws ConfigException {
             String[] nsa = ConfigUtils.splitServerConfig("[2001:db8:85a3:8d3:1319:8a2e:370:7348]:443");
             assertEquals(nsa.length, 2, 0);
    --- End diff --
    
    Assert the actual host and port?


---

Mime
View raw message