zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From breed <...@git.apache.org>
Subject [GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy...
Date Tue, 10 Jul 2018 11:17:37 GMT
Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/561#discussion_r201304300
  
    --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
    @@ -817,10 +817,12 @@ protected void pRequest(Request request) throws RequestProcessorException
{
                                 type = OpCode.error;
                                 txn = new ErrorTxn(e.code().intValue());
     
    -                            LOG.info("Got user-level KeeperException when processing
"
    -                                    + request.toString() + " aborting remaining multi
ops."
    -                                    + " Error Path:" + e.getPath()
    -                                    + " Error:" + e.getMessage());
    +                            if (e.code().intValue() > Code.APIERROR.intValue()) {
    --- End diff --
    
    this one really seems like a debug level to me. the issue is that the client request tried
to do something create a node that already exists. these are very normal cases that the client
is probably expecting (in the case of leader election, for example). we shouldn't be logging
this kind of expected behavior for common operations as INFO


---

Mime
View raw message