zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From breed <...@git.apache.org>
Subject [GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy...
Date Tue, 10 Jul 2018 11:17:12 GMT
Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/561#discussion_r201303257
  
    --- Diff: src/java/main/org/apache/zookeeper/jmx/MBeanRegistry.java ---
    @@ -124,9 +124,7 @@ private void unregister(String path,ZKMBeanInfo bean) throws JMException
 {
                 return;
             if (!bean.isHidden()) {
                 final ObjectName objName = makeObjectName(path, bean);
    -            if (LOG.isInfoEnabled()) {
    -                LOG.info("Unregister MBean [{}]", objName);
    -            }
    +            LOG.debug("Unregister MBean [{}]", objName);
    --- End diff --
    
    any idea why this was in an if clause before. i don't think it was needed, but just checking.


---

Mime
View raw message