zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From breed <...@git.apache.org>
Subject [GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy...
Date Tue, 10 Jul 2018 11:17:12 GMT
Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/561#discussion_r201303059
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -754,7 +754,7 @@ public void finishSessionInit(ServerCnxn cnxn, boolean valid) {
                 cnxn.sendBuffer(bb);
     
                 if (valid) {
    -                LOG.info("Established session 0x"
    +                LOG.debug("Established session 0x"
    --- End diff --
    
    i think this should go to debug. if you have thousands of clients that are reconnecting
after a leader change the log fills with these. if you are really interested in this line
you can add a log4j config that will show it. but this really creates a lot of noise in the
log.


---

Mime
View raw message