zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy...
Date Mon, 09 Jul 2018 12:44:35 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/561#discussion_r200987742
  
    --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
    @@ -817,10 +817,12 @@ protected void pRequest(Request request) throws RequestProcessorException
{
                                 type = OpCode.error;
                                 txn = new ErrorTxn(e.code().intValue());
     
    -                            LOG.info("Got user-level KeeperException when processing
"
    -                                    + request.toString() + " aborting remaining multi
ops."
    -                                    + " Error Path:" + e.getPath()
    -                                    + " Error:" + e.getMessage());
    +                            if (e.code().intValue() > Code.APIERROR.intValue()) {
    --- End diff --
    
    Additionally refactoring this one to use message formatter would be nice.


---

Mime
View raw message